Fifth patch preparing tests for explicit Amount construction
ClosedPublic
Actions

Authored by schancel on Nov 16 2017, 03:37.

Details

Reviewers

deadalnix
freetrader
mbhinder

Group Reviewers

Restricted Project

Commits

rSTAGING2b93e946a1bf: Fifth patch preparing tests for explicit Amount construction
rABC2b93e946a1bf: Fifth patch preparing tests for explicit Amount construction

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

schancel created this revision.Nov 16 2017, 03:37

Harbormaster completed remote builds in B1149: Diff 1791.Nov 16 2017, 03:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 16 2017, 03:37

Herald added a reviewer: Restricted Project. · View Herald Transcript

deadalnix requested changes to this revision.Nov 16 2017, 10:25

deadalnix added inline comments.

src/test/transaction_tests.cpp
111 ↗	(On Diff #1791)	Shouldn't that map contain value to begin with ?

This revision now requires changes to proceed.Nov 16 2017, 10:25

Change map value to be Amount type

deadalnix added inline comments.Nov 16 2017, 22:44

src/test/transaction_tests.cpp
197 ↗	(On Diff #1799)	Why did you changed this ?

schancel added inline comments.Nov 16 2017, 23:05

src/test/transaction_tests.cpp
197 ↗	(On Diff #1799)	I don't like implicit conversion of integers to bool

deadalnix accepted this revision.Nov 22 2017, 19:40

This revision is now accepted and ready to land.Nov 22 2017, 19:40

Closed by commit rABC2b93e946a1bf: Fifth patch preparing tests for explicit Amount construction (authored by schancel). · Explain WhyNov 23 2017, 03:45

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

sighash_tests.cpp

4 lines

sigopcount_tests.cpp

6 lines

test_bitcoin.cpp

4 lines

transaction_tests.cpp

47 lines

Diff 1814

View Options

src/test/sighash_tests.cpp

View Options

src/test/sigopcount_tests.cpp

View Options

src/test/test_bitcoin.cpp

View Options

src/test/transaction_tests.cpp

Fifth patch preparing tests for explicit Amount constructionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1814

src/test/sighash_tests.cpp

src/test/sigopcount_tests.cpp

src/test/test_bitcoin.cpp

src/test/transaction_tests.cpp

Fifth patch preparing tests for explicit Amount construction
ClosedPublic
Actions

Revision Contents
Changeset List