Page MenuHomePhabricator

Fifth patch preparing tests for explicit Amount construction
ClosedPublic

Authored by schancel on Nov 16 2017, 03:37.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Herald added a reviewer: Restricted Project. · View Herald Transcript
deadalnix requested changes to this revision.Nov 16 2017, 10:25
deadalnix added inline comments.
src/test/transaction_tests.cpp
111 ↗(On Diff #1791)

Shouldn't that map contain value to begin with ?

This revision now requires changes to proceed.Nov 16 2017, 10:25

Change map value to be Amount type

src/test/transaction_tests.cpp
197 ↗(On Diff #1799)

Why did you changed this ?

src/test/transaction_tests.cpp
197 ↗(On Diff #1799)

I don't like implicit conversion of integers to bool

This revision is now accepted and ready to land.Nov 22 2017, 19:40
This revision was automatically updated to reflect the committed changes.