Differential D7043

[backport#16557] [wallet] restore coinbase and confirmed/conflicted checks in SubmitMemoryPoolAndRelay()
ClosedPublic
Actions

Authored by majcosta on Jul 27 2020, 16:25.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC0da6d99ee232: [backport#16557] [wallet] restore coinbase and confirmed/conflicted checks in…

Summary

[wallet] Restore confirmed/conflicted tx check in SubmitMemoryPoolAndRelay() (John Newbery)
[wallet] restore coinbase check in SubmitMemoryPoolAndRelay() (John Newbery)

Pull request description:

These checks don't change mempool acceptance/relay behaviour, but reduce log spam.

https://github.com/bitcoin/bitcoin/pull/16557/files

Backport of Core PR16557

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 27 2020, 16:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 27 2020, 16:25

majcosta requested review of this revision.Jul 27 2020, 16:25

Harbormaster completed remote builds in B12169: Diff 22530.Jul 27 2020, 16:42

Fabien accepted this revision.Jul 27 2020, 21:27

This revision is now accepted and ready to land.Jul 27 2020, 21:27

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Closed by commit rABC0da6d99ee232: [backport#16557] [wallet] restore coinbase and confirmed/conflicted checks in… (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyJul 28 2020, 07:15

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC0da6d99ee232: [backport#16557] [wallet] restore coinbase and confirmed/conflicted checks in….

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.h

3 lines

wallet.cpp

25 lines

Diff 22560

View Options

src/wallet/wallet.h