Page MenuHomePhabricator
Differential D7054

[backport#16952] gui: make sure to update the UI when deleting a transaction
ClosedPublic
Actions

Authored by majcosta on Jul 27 2020, 21:04.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb1728a65f1c9: [backport#16952] gui: make sure to update the UI when deleting a transaction
Summary

make sure to update the UI when deleting a transaction (Jonas Schnelli)

Pull request description:

`CWallet::ZapSelectTx` removes transactions from the internal model, but leaves the UI in the dark.
Adding a `NotifyTransactionChanged()` should avoid having invalid transactions in the GUI.

Fixes #16950

https://github.com/bitcoin/bitcoin/pull/16952/commits/addaf8af8268d918973883a304025d40af5a33c1

Backport of Core PR16952

Test Plan
ninja check

Diff Detail

Event Timeline

majcosta created this revision.Jul 27 2020, 21:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 27 2020, 21:04
majcosta requested review of this revision.Jul 27 2020, 21:04
Harbormaster completed remote builds in B12182: Diff 22544.Jul 27 2020, 21:18
Fabien accepted this revision.Jul 27 2020, 21:43
This revision is now accepted and ready to land.Jul 27 2020, 21:43
teamcity edited the summary of this revision. (Show Details)Jul 27 2020, 22:07

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Closed by commit rABCb1728a65f1c9: [backport#16952] gui: make sure to update the UI when deleting a transaction (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by majcosta). · Explain WhyJul 28 2020, 08:26
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCb1728a65f1c9: [backport#16952] gui: make sure to update the UI when deleting a transaction.

Revision Contents
Changeset List

PathSize
src/
wallet/
1 line

Diff 22544

View Options

src/wallet/wallet.cpp

Loading...