Differential D7061

[backport#16402] Remove wallet settings from chainparams
ClosedPublic
Actions

Authored by majcosta on Jul 28 2020, 10:24.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCebb1c14da7c3: [backport#16402] Remove wallet settings from chainparams

Summary

Remove wallet settings from chainparams (MarcoFalke)

Pull request description:

Feels a bit odd to have wallet setting in the chainparams, so remove them from there

https://github.com/bitcoin/bitcoin/pull/16402/commits/fa4a605a4c611abe9af4c18aab20f4d1d039170f

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 28 2020, 10:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 28 2020, 10:24

majcosta requested review of this revision.Jul 28 2020, 10:24

Harbormaster completed remote builds in B12196: Diff 22568.Jul 28 2020, 10:41

majcosta added a child revision: D7062: [backport#16524] Wallet: Disable -fallbackfee by default.Jul 28 2020, 10:44

There is a clearly some previous backports that are missing.

This revision now requires changes to proceed.Jul 28 2020, 12:12

indeed we're missing this https://github.com/bitcoin/bitcoin/pull/11882/files, but I'm not sure we even want anything out of it since this fallback_fee thing is an RBF relic and isn't really used. in fact the only line I'm including in this diff is to be removed in the next D7062.

deadalnix accepted this revision.Jul 31 2020, 13:19

This revision is now accepted and ready to land.Jul 31 2020, 13:19

Closed by commit rABCebb1c14da7c3: [backport#16402] Remove wallet settings from chainparams (authored by MeshCollider <dobsonsa68@gmail.com>, committed by majcosta). · Explain WhyJul 31 2020, 18:04

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCebb1c14da7c3: [backport#16402] Remove wallet settings from chainparams.