Page MenuHomePhabricator

[backport#16402] Remove wallet settings from chainparams
ClosedPublic

Authored by majcosta on Tue, Jul 28, 10:24.

Details

Summary

Remove wallet settings from chainparams (MarcoFalke)

Pull request description:

Feels a bit odd to have wallet setting in the chainparams, so remove them from there

https://github.com/bitcoin/bitcoin/pull/16402/commits/fa4a605a4c611abe9af4c18aab20f4d1d039170f

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.Tue, Jul 28, 10:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jul 28, 10:24
majcosta requested review of this revision.Tue, Jul 28, 10:24
deadalnix requested changes to this revision.Tue, Jul 28, 12:12
deadalnix added a subscriber: deadalnix.

There is a clearly some previous backports that are missing.

This revision now requires changes to proceed.Tue, Jul 28, 12:12
majcosta requested review of this revision.Thu, Jul 30, 17:32

indeed we're missing this https://github.com/bitcoin/bitcoin/pull/11882/files, but I'm not sure we even want anything out of it since this fallback_fee thing is an RBF relic and isn't really used. in fact the only line I'm including in this diff is to be removed in the next D7062.

deadalnix accepted this revision.Fri, Jul 31, 13:19
This revision is now accepted and ready to land.Fri, Jul 31, 13:19