Page MenuHomePhabricator

[CI] Make the bench use the ENABLE_JUNIT_REPORT option and use it on CI
ClosedPublic

Authored by Fabien on Tue, Jul 28, 22:25.

Details

Summary

This adds the required arguments at build system level to generate the
junit report from the benchmark, and simplify the CI script by using
this feature.

Depends on D7064.

Test Plan
ninja bitcoin-bench

Check the bench runs as usual, and prints human readable result.

cmake -GNinja -DENABLE_JUNIT_REPORT=ON
ninja bitcoin-bench

Check the bench reports to a junit file in test/junit

./contrib/teamcity/build-configurations.py build-bench

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Jul 28, 22:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jul 28, 22:25
Fabien requested review of this revision.Tue, Jul 28, 22:25
deadalnix accepted this revision.Fri, Jul 31, 22:24
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
contrib/teamcity/builds/build-bench.sh
16 ↗(On Diff #22596)

Is there a reason to disalow junit ever in tests? Passing this flag seems to only open the door for missing junit generation in some cases.

This revision is now accepted and ready to land.Fri, Jul 31, 22:24