Differential D7070

[CI] Make the bench use the ENABLE_JUNIT_REPORT option and use it on CI
ClosedPublic
Actions

Authored by Fabien on Jul 28 2020, 22:25.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCad8837b6f943: [CI] Make the bench use the ENABLE_JUNIT_REPORT option and use it on CI

Summary

This adds the required arguments at build system level to generate the
junit report from the benchmark, and simplify the CI script by using
this feature.

Depends on D7064.

Test Plan

ninja bitcoin-bench

Check the bench runs as usual, and prints human readable result.

cmake -GNinja -DENABLE_JUNIT_REPORT=ON
ninja bitcoin-bench

Check the bench reports to a junit file in test/junit

./contrib/teamcity/build-configurations.py build-bench

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 28 2020, 22:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 28 2020, 22:25

Fabien requested review of this revision.Jul 28 2020, 22:25

Harbormaster completed remote builds in B12212: Diff 22596.Jul 28 2020, 22:47

deadalnix accepted this revision.Jul 31 2020, 22:24

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

contrib/teamcity/builds/build-bench.sh
16 ↗	(On Diff #22596)	Is there a reason to disalow junit ever in tests? Passing this flag seems to only open the door for missing junit generation in some cases.