Differential D7083

[backport#15963] [tests] Make random seed logged and settable
ClosedPublic
Actions

Authored by majcosta on Jul 29 2020, 17:39.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC524cc44787b0: [backport#15963] [tests] Make random seed logged and settable

Summary

[tests] Make random seed logged and settable (John Newbery)

Pull request description:

  This allows tests which use randomness to be reproducibly run on

failure.

https://github.com/bitcoin/bitcoin/pull/15963/files

Depends on D7081

Backport of Core PR15963

Test Plan

ninja
cd test
../../test/functional/[test_name] --config=config.ini --randomseed=[random_seed]

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 29 2020, 17:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 29 2020, 17:39

majcosta requested review of this revision.Jul 29 2020, 17:39

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12226: Diff 22613.Jul 29 2020, 17:54

majcosta added a child revision: D7084: [backport#17633] tests: Add option --valgrind to run the functional tests under Valgrind.Jul 29 2020, 18:08

Fabien accepted this revision.Jul 29 2020, 21:16

This revision is now accepted and ready to land.Jul 29 2020, 21:16

Closed by commit rABC524cc44787b0: [backport#15963] [tests] Make random seed logged and settable (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyJul 30 2020, 00:34

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC524cc44787b0: [backport#15963] [tests] Make random seed logged and settable.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

test_framework.py

19 lines

Diff 22632

View Options

test/functional/test_framework/test_framework.py

[backport#15963] [tests] Make random seed logged and settableClosedPublicActions