Page MenuHomePhabricator
Differential D7123

[backport#16383 3/3] tests: functional watch-only wallet tests
ClosedPublic
Actions

Authored by majcosta on Aug 4 2020, 12:38.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC9cfb6eb98a3d: [backport#16383 3/3] tests: functional watch-only wallet tests
Summary

These test the new watch-only defaults for rpcs with include_watchonly
and includeWatching options.

Signed-off-by: William Casarin <jb55@jb55.com>

https://github.com/bitcoin/bitcoin/pull/16383/commits/72eaab073bc747425fe551777154b13a6c4c37c9

doc: add release note for include_watchonly default changes

Signed-off-by: William Casarin <jb55@jb55.com>

https://github.com/bitcoin/bitcoin/pull/16383/commits/72ffbdc5799c1707ecad674d701b43fb80b031d0

Depends on D7122

Concludes backport of Core PR16383

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Aug 4 2020, 12:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 4 2020, 12:38
majcosta requested review of this revision.Aug 4 2020, 12:38
teamcity edited the summary of this revision. (Show Details)Aug 4 2020, 12:38

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12297: Diff 22728.Aug 4 2020, 12:52
deadalnix requested changes to this revision.Aug 4 2020, 22:43
deadalnix added a subscriber: deadalnix.

You need to add the --usecli version of the test to the test runner.

This revision now requires changes to proceed.Aug 4 2020, 22:43
majcosta updated this revision to Diff 22746.Aug 5 2020, 04:58

included wallet_watchonly to test_runner.py list of --usecli compatible tests

Harbormaster completed remote builds in B12310: Diff 22746.Aug 5 2020, 05:16
deadalnix accepted this revision.Aug 7 2020, 14:47
This revision is now accepted and ready to land.Aug 7 2020, 14:47
Closed by commit rABC9cfb6eb98a3d: [backport#16383 3/3] tests: functional watch-only wallet tests (authored by William Casarin <jb55@jb55.com>, committed by majcosta). · Explain WhyAug 7 2020, 18:33
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC9cfb6eb98a3d: [backport#16383 3/3] tests: functional watch-only wallet tests.

Revision Contents
Changeset List

PathSize
doc/
9 lines
test/
functional/
1 line
120 lines

Diff 22814

View Options

doc/release-notes.md

Loading...
View Options

test/functional/test_runner.py

Loading...
View Options

test/functional/wallet_watchonly.py

Loading...