Page MenuHomePhabricator
Differential D7139

Add signed right shift assumption in assumptions.h
ClosedPublic
Actions

Authored by deadalnix on Aug 6 2020, 16:25.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCdf80432589c2: Add signed right shift assumption in assumptions.h
Summary

As per title.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
assumesignedshift
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12319
Build 24834: Build Diffbuild-diff · build-clang-10 · build-without-wallet · build-clang-tidy
Build 24833: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 6 2020, 16:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 6 2020, 16:25
deadalnix requested review of this revision.Aug 6 2020, 16:25
majcosta accepted this revision.Aug 6 2020, 16:26
This revision is now accepted and ready to land.Aug 6 2020, 16:26
This revision was landed with ongoing or failed builds.Aug 6 2020, 16:28
Closed by commit rABCdf80432589c2: Add signed right shift assumption in assumptions.h (authored by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCdf80432589c2: Add signed right shift assumption in assumptions.h.
Harbormaster completed remote builds in B12319: Diff 22764.Aug 6 2020, 16:39
teamcity added a comment.Aug 6 2020, 16:39
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

rpc_deriveaddresses.py --usecli         | ✓ Passed  | 1 s
rpc_estimatefee.py                      | ✓ Passed  | 1 s
rpc_getblockfilter.py                   | ✓ Passed  | 1 s
rpc_getblockstats.py                    | ✓ Passed  | 1 s
rpc_getchaintips.py                     | ✓ Passed  | 2 s
rpc_help.py                             | ✓ Passed  | 1 s
rpc_invalidateblock.py                  | ✓ Passed  | 6 s
rpc_misc.py                             | ✓ Passed  | 1 s
rpc_named_arguments.py                  | ✓ Passed  | 1 s
rpc_net.py                              | ✓ Passed  | 1 s
rpc_preciousblock.py                    | ✓ Passed  | 1 s
rpc_psbt.py                             | ✓ Passed  | 47 s
rpc_scantxoutset.py                     | ✓ Passed  | 5 s
rpc_setban.py                           | ✓ Passed  | 2 s
rpc_signmessage.py                      | ✓ Passed  | 1 s
rpc_signrawtransaction.py               | ✓ Passed  | 1 s
rpc_txoutproof.py                       | ✓ Passed  | 2 s
rpc_uptime.py                           | ✓ Passed  | 1 s
rpc_users.py                            | ✓ Passed  | 2 s
rpc_whitelist.py                        | ✓ Passed  | 1 s
tool_wallet.py                          | ✓ Passed  | 4 s
wallet_abandonconflict.py               | ✓ Passed  | 10 s
wallet_address_types.py                 | ✓ Passed  | 15 s
wallet_avoidreuse.py                    | ✓ Passed  | 3 s
wallet_backup.py                        | ✓ Passed  | 44 s
wallet_balance.py                       | ✓ Passed  | 24 s
wallet_basic.py                         | ✓ Passed  | 24 s
wallet_create_tx.py                     | ✓ Passed  | 13 s
wallet_createwallet.py                  | ✓ Passed  | 3 s
wallet_createwallet.py --usecli         | ✓ Passed  | 3 s
wallet_disable.py                       | ✓ Passed  | 0 s
wallet_dump.py                          | ✓ Passed  | 3 s
wallet_encryption.py                    | ✓ Passed  | 5 s
wallet_groups.py                        | ✓ Passed  | 14 s
wallet_hd.py                            | ✓ Passed  | 7 s
wallet_import_rescan.py                 | ✓ Passed  | 9 s
wallet_import_with_label.py             | ✓ Passed  | 1 s
wallet_importmulti.py                   | ✓ Passed  | 3 s
wallet_importprunedfunds.py             | ✓ Passed  | 2 s
wallet_keypool.py                       | ✓ Passed  | 3 s
wallet_keypool_topup.py                 | ✓ Passed  | 2 s
wallet_labels.py                        | ✓ Passed  | 2 s
wallet_listreceivedby.py                | ✓ Passed  | 14 s
wallet_listsinceblock.py                | ✓ Passed  | 6 s
wallet_listtransactions.py              | ✓ Passed  | 12 s
wallet_multiwallet.py                   | ✓ Passed  | 14 s
wallet_multiwallet.py --usecli          | ✓ Passed  | 15 s
wallet_reorgsrestore.py                 | ✓ Passed  | 3 s
wallet_resendwallettransactions.py      | ✓ Passed  | 32 s
wallet_txn_clone.py                     | ✓ Passed  | 2 s
wallet_txn_clone.py --mineblock         | ✓ Passed  | 3 s
wallet_txn_doublespend.py               | ✓ Passed  | 1 s
wallet_txn_doublespend.py --mineblock   | ✓ Passed  | 3 s
wallet_zapwallettxes.py                 | ✓ Passed  | 4 s

ALL                                     | ✓ Passed  | 795 s (accumulated) 
Runtime: 160 s

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

Each failure log is accessible here:
Bitcoin ABC functional tests: wallet_keypool.py

Revision Contents
Changeset List

PathSize
src/
compat/
13 lines

Diff 22764

View Options

src/compat/assumptions.h

Loading...