Differential D715

A pack of nits in txmempool.cpp
ClosedPublic
Actions

Authored by deadalnix on Nov 25 2017, 02:38.

Details

Reviewers

schancel

Group Reviewers

Restricted Project

Commits

rSTAGING5d7448223cfe: A pack of nits in txmempool.cpp
rABC5d7448223cfe: A pack of nits in txmempool.cpp

Summary

As per title.

Test Plan

make check
../qa/pull-tester/rpc-tests.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Nov 25 2017, 02:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2017, 02:38

Harbormaster completed remote builds in B1166: Diff 1826.Nov 25 2017, 02:38

More nits

Harbormaster completed remote builds in B1167: Diff 1827.Nov 25 2017, 13:50

deadalnix added a child revision: D716: Remove GetConfig call from removeForReorg.Nov 25 2017, 14:08

Looks good. One test failed, suspect it's one of the flaky ones. Rerunning and will investigate the failure.

schancel accepted this revision.Nov 26 2017, 05:58

This revision is now accepted and ready to land.Nov 26 2017, 05:58

Closed by commit rABC5d7448223cfe: A pack of nits in txmempool.cpp (authored by deadalnix). · Explain WhyNov 26 2017, 17:42

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

txmempool.h

8 lines

txmempool.cpp

175 lines

Diff 1837

View Options

src/txmempool.h