This makes it easier to pinpoint when an activation has occurred.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project
ninja check check-functional ./src/bitcoind -regtest -axionactivationtime=$((($(date +%s) + 5)))
Repeat this until you see the log message:
./bitcoin-cli -regtest generatetoaddress 1 "bchreg:qpjr5703huq6yulx2s48rl23h8kujs05rydq22kppt"
Repeat it some more to make sure the log message doesn't continue to appear.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- log-activations
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 12391 Build 24957: Build Diff build-clang-tidy · build-diff · build-without-wallet · build-clang-10 Build 24956: arc lint + arc unit
Event Timeline
Comment Actions
I'm not convinced this is very helpful:
- The only time this is really useful is at fork time, where everybody is monitoring the MTP already.
- Other non devs that failed to upgrade will still see the message, which causes confusion.
- These names are code names and only relevant to a few devs.
- Past upgrades are not really useful. The code for great wall has already been removed and won't appear for example.
IMO it is not worth it due to the added maintenance cost.
| src/validation.cpp | ||
|---|---|---|
| 2035 | Pass by reference | |