Page MenuHomePhabricator
Differential D7201

Output proper coinbase value in getblocktemplate once the new coinbase rule is active
ClosedPublic
Actions

Authored by deadalnix on Aug 15 2020, 22:42.

Details

Reviewers
jasonbcox
majcosta
Group Reviewers
Restricted Project
Commits
rABCf8360b5e9811: Output proper coinbase value in getblocktemplate once the new coinbase rule is…
Summary

This ensures that the coinbase value is properly reported by the getblocktemplate RPC.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Aug 15 2020, 22:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 15 2020, 22:42
deadalnix requested review of this revision.Aug 15 2020, 22:42
jasonbcox accepted this revision.Aug 15 2020, 22:46
jasonbcox added a subscriber: jasonbcox.

Ideally this needs a test, but there's a lot to be desired in the existing mining tests...

This revision is now accepted and ready to land.Aug 15 2020, 22:46
majcosta accepted this revision.Aug 15 2020, 22:50
This revision was landed with ongoing or failed builds.Aug 15 2020, 22:52
Closed by commit rABCf8360b5e9811: Output proper coinbase value in getblocktemplate once the new coinbase rule is… (authored by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCf8360b5e9811: Output proper coinbase value in getblocktemplate once the new coinbase rule is….
jasonbcox mentioned this in T1014: Improve test coverage for ABC-specific behaviors in getblocktemplate.Aug 15 2020, 22:54
Harbormaster completed remote builds in B12400: Diff 22915.Aug 15 2020, 22:56
jasonbcox mentioned this in D7230: Add a test for ABC-specific getblocktemplate behavior.Aug 20 2020, 20:41
jasonbcox mentioned this in rABCf02132a0d60b: Add a test for ABC-specific getblocktemplate behavior.Aug 24 2020, 15:24

Revision Contents
Changeset List

PathSize
src/
rpc/
12 lines

Diff 22916

View Options

src/rpc/mining.cpp

Loading...