Differential D7233

Add test coverage for getblocktemplate's mintime
ClosedPublic
Actions

Authored by jasonbcox on Aug 20 2020, 22:28.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa341679b4c13: Add test coverage for getblocktemplate's mintime

Summary

mintime is not tested anywhere. Rather than introduce a new merge conflict
in mining_basic.py we can test it here.

Part of T1014

Depends on D7230

Test Plan

test_runner.py abc_mining_basic

Diff Detail

Repository

rABC Bitcoin ABC

Branch

more-gbt-tests

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12443
Build 25047: Build Diff	build-without-wallet · build-diff · build-clang-tidy · build-clang-10
Build 25046: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Aug 20 2020, 22:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 20 2020, 22:28

jasonbcox requested review of this revision.Aug 20 2020, 22:28

jasonbcox edited the summary of this revision. (Show Details)Aug 20 2020, 22:37

jasonbcox added a parent revision: D7230: Add a test for ABC-specific getblocktemplate behavior.

jasonbcox added a child revision: D7234: Add test coverage for getblocktemplate's sigoplimit.Aug 20 2020, 22:39

jasonbcox edited the summary of this revision. (Show Details)Aug 20 2020, 22:40

Harbormaster completed remote builds in B12443: Diff 22996.Aug 20 2020, 22:54

jasonbcox added a child revision: D7235: Add miner fund address list to getblocktemplate output.Aug 20 2020, 23:13

Fabien accepted this revision.Aug 21 2020, 06:36

This revision is now accepted and ready to land.Aug 21 2020, 06:36

Closed by commit rABCa341679b4c13: Add test coverage for getblocktemplate's mintime (authored by jasonbcox). · Explain WhyAug 24 2020, 15:43

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCa341679b4c13: Add test coverage for getblocktemplate's mintime.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_mining_basic.py

10 lines

Diff 22996

View Options

test/functional/abc_mining_basic.py

Add test coverage for getblocktemplate's mintimeClosedPublicActions