Page MenuHomePhabricator

[CI] Prevent stdout buffer overflow
ClosedPublic

Authored by Fabien on Aug 26 2020, 22:24.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC95e622d9ac42: [CI] Prevent stdout buffer overflow
Summary

This diff increases the StreamReader buffer size which is responsible
for handling the stdout and stderr output of the running process. It
also handles the exception in case of overflow so that the script will
continue to run and behave normally, with a notice that a line get
dropped.
This case currently occurs on CI during coverage builds:
https://build.bitcoinabc.org/viewLog.html?buildId=44175&buildTypeId=BitcoinABC_Master_BitcoinAbcMasterCoverage&tab=buildLog

Test Plan

Change the buffer size to something absurdly low and run a build.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ci_stdout_buffer
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12475
Build 25101: Build Diffbuild-without-wallet · build-clang-10 · build-diff · build-clang-tidy
Build 25100: arc lint + arc unit