Page MenuHomePhabricator
Differential D7274

[backport#17342][tests] Don't use nScriptCheckThreads in the checkqueue_tests
ClosedPublic
Actions

Authored by majcosta on Aug 31 2020, 20:08.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC02aca79cc39d: [backport#17342][tests] Don't use nScriptCheckThreads in the checkqueue_tests
Summary

It's only needed for a hardcoded int, which we can define locally.

Note from Backporter: Core's description of this is indeed somewhat confusing. nScriptCheckThreads is removed in the next commit.

https://github.com/bitcoin/bitcoin/pull/17342/commits/d9957623b48a7c3eff0ac750d1245fabfb1843a2

Partial backport of Core PR17342

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Aug 31 2020, 20:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 31 2020, 20:08
majcosta requested review of this revision.Aug 31 2020, 20:08
teamcity edited the summary of this revision. (Show Details)Aug 31 2020, 20:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7275: [backport#17342][refactor] Remove global int nScriptCheckThreads.Aug 31 2020, 20:09
Harbormaster completed remote builds in B12504: Diff 23098.Aug 31 2020, 20:21
jasonbcox requested changes to this revision.Aug 31 2020, 21:20
jasonbcox added a subscriber: jasonbcox.

It's not clear from the Github history whether this commit was outdated from the start or what, but the commit message does not match the patch. There is some indication that the refactor took a turn for a better design though. Please fix this otherwise it's just confusing in our own git history.

This revision now requires changes to proceed.Aug 31 2020, 21:20
majcosta requested review of this revision.Aug 31 2020, 21:38
majcosta retitled this revision from [backport#17342][tests] Don't use TestingSetup in the checkqueue_tests to [backport#17342][tests] Don't use nScriptCheckThreads in the checkqueue_tests.
majcosta edited the summary of this revision. (Show Details)

indeed this is confusing, hope it's clearer now

jasonbcox accepted this revision.Aug 31 2020, 22:08
This revision is now accepted and ready to land.Aug 31 2020, 22:08
Closed by commit rABC02aca79cc39d: [backport#17342][tests] Don't use nScriptCheckThreads in the checkqueue_tests (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhySep 1 2020, 12:20
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC02aca79cc39d: [backport#17342][tests] Don't use nScriptCheckThreads in the checkqueue_tests.

Revision Contents
Changeset List

PathSize
src/
test/
16 lines

Diff 23116

View Options

src/test/checkqueue_tests.cpp

Loading...