Page MenuHomePhabricator
Differential D7278

[backport#14771]test: Add BOOST_REQUIRE to getters returning optional
ClosedPublic
Actions

Authored by majcosta on Aug 31 2020, 20:59.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCff322359f49d: [backport#14771]test: Add BOOST_REQUIRE to getters returning optional
Summary

https://github.com/bitcoin/bitcoin/pull/14771/commits/fa21ca09a807e18476babe2651ad62df6477bbf0

Backport of Core PR14771

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Aug 31 2020, 20:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 31 2020, 20:59
majcosta requested review of this revision.Aug 31 2020, 20:59
teamcity edited the summary of this revision. (Show Details)Aug 31 2020, 20:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12508: Diff 23103.Aug 31 2020, 21:09
teamcity added a comment.Aug 31 2020, 21:10
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

rpc_estimatefee.py                      | ✓ Passed  | 1 s
rpc_getblockfilter.py                   | ✓ Passed  | 1 s
rpc_getblockstats.py                    | ✓ Passed  | 1 s
rpc_getchaintips.py                     | ✓ Passed  | 3 s
rpc_help.py                             | ✓ Passed  | 1 s
rpc_invalidateblock.py                  | ✓ Passed  | 6 s
rpc_misc.py                             | ✓ Passed  | 1 s
rpc_named_arguments.py                  | ✓ Passed  | 1 s
rpc_net.py                              | ✓ Passed  | 1 s
rpc_preciousblock.py                    | ✓ Passed  | 1 s
rpc_psbt.py                             | ✓ Passed  | 16 s
rpc_scantxoutset.py                     | ✓ Passed  | 4 s
rpc_setban.py                           | ✓ Passed  | 2 s
rpc_signmessage.py                      | ✓ Passed  | 1 s
rpc_signrawtransaction.py               | ✓ Passed  | 1 s
rpc_txoutproof.py                       | ✓ Passed  | 2 s
rpc_uptime.py                           | ✓ Passed  | 1 s
rpc_users.py                            | ✓ Passed  | 2 s
rpc_whitelist.py                        | ✓ Passed  | 1 s
tool_wallet.py                          | ✓ Passed  | 3 s
wallet_abandonconflict.py               | ✓ Passed  | 11 s
wallet_address_types.py                 | ✓ Passed  | 14 s
wallet_avoidreuse.py                    | ✓ Passed  | 1 s
wallet_balance.py                       | ✓ Passed  | 24 s
wallet_basic.py                         | ✓ Passed  | 25 s
wallet_create_tx.py                     | ✓ Passed  | 9 s
wallet_createwallet.py                  | ✓ Passed  | 3 s
wallet_createwallet.py --usecli         | ✓ Passed  | 4 s
wallet_disable.py                       | ✓ Passed  | 0 s
wallet_dump.py                          | ✓ Passed  | 3 s
wallet_encryption.py                    | ✓ Passed  | 6 s
wallet_groups.py                        | ✓ Passed  | 12 s
wallet_hd.py                            | ✓ Passed  | 6 s
wallet_import_rescan.py                 | ✓ Passed  | 5 s
wallet_import_with_label.py             | ✓ Passed  | 1 s
wallet_importmulti.py                   | ✓ Passed  | 3 s
wallet_importprunedfunds.py             | ✓ Passed  | 2 s
wallet_keypool.py                       | ✓ Passed  | 3 s
wallet_keypool_topup.py                 | ✓ Passed  | 2 s
wallet_labels.py                        | ✓ Passed  | 1 s
wallet_listreceivedby.py                | ✓ Passed  | 27 s
wallet_listsinceblock.py                | ✓ Passed  | 4 s
wallet_listtransactions.py              | ✓ Passed  | 8 s
wallet_multiwallet.py                   | ✓ Passed  | 12 s
wallet_multiwallet.py --usecli          | ✓ Passed  | 18 s
wallet_reorgsrestore.py                 | ✓ Passed  | 3 s
wallet_resendwallettransactions.py      | ✓ Passed  | 10 s
wallet_txn_clone.py                     | ✓ Passed  | 1 s
wallet_txn_clone.py --mineblock         | ✓ Passed  | 3 s
wallet_txn_doublespend.py               | ✓ Passed  | 1 s
wallet_txn_doublespend.py --mineblock   | ✓ Passed  | 3 s
wallet_watchonly.py                     | ✓ Passed  | 1 s
wallet_watchonly.py --usecli            | ✓ Passed  | 1 s
wallet_zapwallettxes.py                 | ✓ Passed  | 3 s

ALL                                     | ✓ Passed  | 660 s (accumulated) 
Runtime: 132 s

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

Each failure log is accessible here:
Bitcoin ABC functional tests: abc-cmdline.py

majcosta updated this revision to Diff 23115.Sep 1 2020, 02:04

rebase

Harbormaster completed remote builds in B12518: Diff 23115.Sep 1 2020, 02:27
Fabien added a subscriber: Fabien.Sep 1 2020, 06:45
Fabien added inline comments.
src/test/coins_tests.cpp
9 ↗(On Diff #23115)

Is that necessary ?
In the PR it's only sorted, not added.

deadalnix requested changes to this revision.Sep 1 2020, 13:28
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/test/coins_tests.cpp
9 ↗(On Diff #23115)

+1

src/util/system.h
209 ↗(On Diff #23115)

YEAH! ccache trashing XD

This revision now requires changes to proceed.Sep 1 2020, 13:28
majcosta updated this revision to Diff 23130.Sep 1 2020, 15:09

that was not necessary indeed, thank you reviewers!

deadalnix accepted this revision.Sep 1 2020, 15:11
This revision is now accepted and ready to land.Sep 1 2020, 15:11
This revision was landed with ongoing or failed builds.Sep 1 2020, 15:14
Closed by commit rABCff322359f49d: [backport#14771]test: Add BOOST_REQUIRE to getters returning optional (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain Why
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCff322359f49d: [backport#14771]test: Add BOOST_REQUIRE to getters returning optional.
Harbormaster completed remote builds in B12527: Diff 23130.Sep 1 2020, 15:24

Revision Contents
Changeset List

PathSize
src/
test/
4 lines
8 lines
util/
3 lines

Diff 23132

View Options

src/test/coins_tests.cpp

Loading...
View Options

src/test/dbwrapper_tests.cpp

Loading...
View Options

src/util/system.h

Loading...