Page MenuHomePhabricator
Differential D7289

[backport#15886]Make SendConfirmationDialog fully fledged
ClosedPublic
Actions

Authored by majcosta on Sep 1 2020, 14:58.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC5cf11c4c879b: [backport#15886]Make SendConfirmationDialog fully fledged
Summary

The property-based API has been used. Added support for the
informativeText and detailedText properties.

https://github.com/bitcoin/bitcoin/pull/15886/commits/654e419549fb5f1c360843d48e66eb098bbf5a83

Partial backport of Core PR15886

Test Plan
ninja

run bitcoin-qt in regtest mode and check things out

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 1 2020, 14:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 1 2020, 14:58
majcosta requested review of this revision.Sep 1 2020, 14:58
teamcity edited the summary of this revision. (Show Details)Sep 1 2020, 14:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Sep 1 2020, 15:07
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/qt/sendcoinsdialog.cpp
928 ↗(On Diff #23127)

Put comment on the previous line.

This revision now requires changes to proceed.Sep 1 2020, 15:07
Harbormaster completed remote builds in B12524: Diff 23127.Sep 1 2020, 15:07
majcosta updated this revision to Diff 23131.Sep 1 2020, 15:12

put comment on its rightful place

deadalnix accepted this revision.Sep 1 2020, 15:16
This revision is now accepted and ready to land.Sep 1 2020, 15:16
Harbormaster completed remote builds in B12528: Diff 23131.Sep 1 2020, 15:28
Closed by commit rABC5cf11c4c879b: [backport#15886]Make SendConfirmationDialog fully fledged (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by majcosta). · Explain WhySep 1 2020, 15:29
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC5cf11c4c879b: [backport#15886]Make SendConfirmationDialog fully fledged.

Revision Contents
Changeset List

PathSize
src/
qt/
2 lines
16 lines

Diff 23133

View Options

src/qt/sendcoinsdialog.h

Loading...
View Options

src/qt/sendcoinsdialog.cpp

Loading...