Page MenuHomePhabricator

[backport#15886]Make SendConfirmationDialog fully fledged
ClosedPublic

Authored by majcosta on Sep 1 2020, 14:58.

Details

Summary

The property-based API has been used. Added support for the
informativeText and detailedText properties.

https://github.com/bitcoin/bitcoin/pull/15886/commits/654e419549fb5f1c360843d48e66eb098bbf5a83


Partial backport of Core PR15886

Test Plan
ninja

run bitcoin-qt in regtest mode and check things out

Event Timeline

majcosta requested review of this revision.Sep 1 2020, 14:58

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Sep 1 2020, 15:07
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/qt/sendcoinsdialog.cpp
928 ↗(On Diff #23127)

Put comment on the previous line.

This revision now requires changes to proceed.Sep 1 2020, 15:07

put comment on its rightful place

This revision is now accepted and ready to land.Sep 1 2020, 15:16