Page MenuHomePhabricator
Differential D7292

[backport#16964] gui: Change sendcoins dialogue Yes to Send
ClosedPublic
Actions

Authored by majcosta on Sep 1 2020, 15:33.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCad7f8efecaf3: [backport#16964] gui: Change sendcoins dialogue Yes to Send
Summary

Change sendcoins dialogue Yes to Send (Gregory Sanders)

Pull request description:

It's more self-explanatory, matches "cancel" better, and makes future extensions such as https://github.com/bitcoin/bitcoin/pull/16944 more directly understandable to the user.

https://github.com/bitcoin/bitcoin/pull/16964/commits/a649cc6a17b8d8d602c6b67037b0c926960f9cdb

Backport of Core PR16964

Test Plan
ninja
./src/qt/bitcoin-qt -regtest

send myself money, see 'Send' instead of 'Yes'

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 1 2020, 15:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 1 2020, 15:33
majcosta requested review of this revision.Sep 1 2020, 15:33
teamcity edited the summary of this revision. (Show Details)Sep 1 2020, 15:34

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7293: [backport#16944][wallet] ListCoins: include watch-only for wallets without private keys.Sep 1 2020, 15:39
deadalnix accepted this revision.Sep 1 2020, 16:41
This revision is now accepted and ready to land.Sep 1 2020, 16:41
This revision was landed with ongoing or failed builds.Sep 1 2020, 16:42
Closed by commit rABCad7f8efecaf3: [backport#16964] gui: Change sendcoins dialogue Yes to Send (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain Why
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCad7f8efecaf3: [backport#16964] gui: Change sendcoins dialogue Yes to Send.

Revision Contents
Changeset List

PathSize
src/
qt/
4 lines

Diff 23145

View Options

src/qt/sendcoinsdialog.cpp

Loading...