Differential D7312

[backport#14478] Show error to user when corrupt wallet unlock fails
ClosedPublic
Actions

Authored by majcosta on Sep 2 2020, 16:01.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABCb8b40a6e66a9: [backport#14478] Show error to user when corrupt wallet unlock fails

Summary

Better error message for user when corrupt wallet unlock fails (MeshCollider)

Pull request description:

Mentioned here: https://github.com/bitcoin/bitcoin/issues/14461#issuecomment-429183503

Current behavior is to assert(false) and crash, only info is printed in the log. This shows the message to the user before abort() instead.

https://github.com/bitcoin/bitcoin/pull/14478/commits/b4f6e58ca5a74225b6db9deb3ffe1ce3ab19a790

Backport of Core PR14478

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 2 2020, 16:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 2 2020, 16:01

majcosta requested review of this revision.Sep 2 2020, 16:01

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12552: Diff 23174.Sep 2 2020, 16:16

jasonbcox accepted this revision.Sep 2 2020, 18:00

This revision is now accepted and ready to land.Sep 2 2020, 18:00

Closed by commit rABCb8b40a6e66a9: [backport#14478] Show error to user when corrupt wallet unlock fails (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhySep 2 2020, 18:34

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCb8b40a6e66a9: [backport#14478] Show error to user when corrupt wallet unlock fails.

Revision Contents
Changeset List

Path

Size

src/

qt/

askpassphrasedialog.cpp

17 lines

wallet/

scriptpubkeyman.cpp

4 lines

Diff 23183

View Options

src/qt/askpassphrasedialog.cpp