Page MenuHomePhabricator

[backport#14478] Show error to user when corrupt wallet unlock fails
ClosedPublic

Authored by majcosta on Sep 2 2020, 16:01.

Details

Summary

Better error message for user when corrupt wallet unlock fails (MeshCollider)

Pull request description:

Mentioned here: https://github.com/bitcoin/bitcoin/issues/14461#issuecomment-429183503

Current behavior is to assert(false) and crash, only info is printed in the log. This shows the message to the user before abort() instead.

https://github.com/bitcoin/bitcoin/pull/14478/commits/b4f6e58ca5a74225b6db9deb3ffe1ce3ab19a790


Backport of Core PR14478

Test Plan
ninja check

Diff Detail

Event Timeline

majcosta requested review of this revision.Sep 2 2020, 16:01

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Sep 2 2020, 18:00