Differential D7322

[backport#14268] Introduce SafeDbt to handle DB_DBT_MALLOC raii-style
ClosedPublic
Actions

Authored by majcosta on Sep 2 2020, 19:36.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC481508fdbcba: [backport#14268] Introduce SafeDbt to handle DB_DBT_MALLOC raii-style

Summary

This provides additional exception-safety and case handling for the proper
freeing of the associated buffers.

https://github.com/bitcoin/bitcoin/pull/14268/commits/1a9f9f7e5e2e73fb832f5b96ad7e9e57954f3f3c

Depends on D7321

Partial backport of Core PR14268

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 2 2020, 19:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 2 2020, 19:36

majcosta requested review of this revision.Sep 2 2020, 19:36

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7323: [backport#14268] Make SafeDbt DB_DBT_MALLOC on default initialization.Sep 2 2020, 19:38

Fabien accepted this revision.Sep 2 2020, 19:53

This revision is now accepted and ready to land.Sep 2 2020, 19:53

Harbormaster completed remote builds in B12564: Diff 23194.Sep 2 2020, 20:02

Closed by commit rABC481508fdbcba: [backport#14268] Introduce SafeDbt to handle DB_DBT_MALLOC raii-style (authored by Ben Woosley <ben.woosley@gmail.com>, committed by majcosta). · Explain WhySep 2 2020, 20:30

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC481508fdbcba: [backport#14268] Introduce SafeDbt to handle DB_DBT_MALLOC raii-style.

Revision Contents
Changeset List

Path

Size

src/

wallet/

db.h

70 lines

db.cpp

31 lines

Diff 23203

View Options

src/wallet/db.h