Differential D7368

[backport#16144] wallet: do not encrypt wallets with disabled private keys
ClosedPublic
Actions

Authored by majcosta on Sep 4 2020, 18:31.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC147355c881a5: [backport#16144] wallet: do not encrypt wallets with disabled private keys

Summary

wallet: do not encrypt wallets with disabled private keys (whythat)

Pull request description:

Fix for #15635.
Throw an `RPC_WALLET_ENCRYPTION_FAILED` error when attempting to encrypt wallet with disabled private keys. Changed `test/function/wallet_createwallet.py` to test new behavior.

Backport of Core PR16144

Test Plan

ninja check
test_runner.py wallet_createwallet

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 4 2020, 18:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2020, 18:31

majcosta requested review of this revision.Sep 4 2020, 18:31

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12628: Diff 23308.Sep 4 2020, 18:54

Fabien accepted this revision.Sep 4 2020, 20:23

This revision is now accepted and ready to land.Sep 4 2020, 20:23

Closed by commit rABC147355c881a5: [backport#16144] wallet: do not encrypt wallets with disabled private keys (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhySep 5 2020, 02:09

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC147355c881a5: [backport#16144] wallet: do not encrypt wallets with disabled private keys.

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcwallet.cpp

6 lines

test/

functional/

wallet_createwallet.py

5 lines

Diff 23332

View Options

src/wallet/rpcwallet.cpp