HomePhabricator

[backport#16144] wallet: do not encrypt wallets with disabled private keys

Description

[backport#16144] wallet: do not encrypt wallets with disabled private keys

Summary:
wallet: do not encrypt wallets with disabled private keys (whythat)

Pull request description:

Fix for #15635.
Throw an `RPC_WALLET_ENCRYPTION_FAILED` error when attempting to encrypt wallet with disabled private keys. Changed `test/function/wallet_createwallet.py` to test new behavior.

Backport of Core PR16144

Test Plan:

ninja check
test_runner.py wallet_createwallet

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7368

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Jun 5 2019, 10:47
majcostaCommitted on Sep 5 2020, 02:09
majcostaPushed on Sep 5 2020, 02:09
Reviewer
Restricted Project
Differential Revision
D7368: [backport#16144] wallet: do not encrypt wallets with disabled private keys
Parents
rABC0f4d92ca24b0: [land-bot] Extract out conduit token sanitization code
Branches
Unknown
Tags
Unknown