Differential D7370

[backport#16185 1/3] gettransaction: add an argument to decode the transaction
ClosedPublic
Actions

Authored by majcosta on Sep 4 2020, 19:34.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC28501c5d74f9: [backport#16185 1/3] gettransaction: add an argument to decode the transaction

Summary

This adds a new boolean parameter 'decode' to the gettransaction call, which, if set to true, add a 'decoded' field to the result containing the decoded transaction

https://github.com/bitcoin/bitcoin/pull/16185/commits/7f3bb247a811582d1aa4805d8e601c19808dc7ba

Partial backport of Core PR16185

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 4 2020, 19:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2020, 19:34

majcosta requested review of this revision.Sep 4 2020, 19:34

Harbormaster completed remote builds in B12630: Diff 23312.Sep 4 2020, 19:34

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7371: [backport#16185 2/3] tests: Add a new functional test for gettransaction.Sep 4 2020, 19:34

Fabien accepted this revision.Sep 4 2020, 21:26

This revision is now accepted and ready to land.Sep 4 2020, 21:26

Closed by commit rABC28501c5d74f9: [backport#16185 1/3] gettransaction: add an argument to decode the transaction (authored by darosior <darosior@protonmail.com>, committed by majcosta). · Explain WhySep 5 2020, 21:57

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC28501c5d74f9: [backport#16185 1/3] gettransaction: add an argument to decode the transaction.

Revision Contents
Changeset List

Path

Size

src/

rpc/

client.cpp

1 line

wallet/

rpcwallet.cpp

18 lines

Diff 23334

View Options

src/rpc/client.cpp