Page MenuHomePhabricator
Differential D7385

[backport#16689 2/2] Add missing fields in TransactionDescriptionString and others
ClosedPublic
Actions

Authored by majcosta on Sep 7 2020, 20:53.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC39f861a08167: [backport#16689 2/2] Add missing fields in TransactionDescriptionString and…
Summary

Fields involvesWatchonly, generated, walletconflicts were missing
in result description of listtransactions, listsinceblock,
gettransaction

Align getttransaction fields which were odd compare to other rpc
helpers

https://github.com/bitcoin/bitcoin/pull/16689/commits/f4c8953b0073e6bc37abd18ec4a5cbc3ea9719a1

Depends on D7384

Concludes backport of Core PR16689

Test Plan
ninja
bitcoin-cli help listreceivedbyaddress|listreceivedbylabel|listtransactions|listsinceblock|gettransaction

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 7 2020, 20:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 7 2020, 20:53
majcosta requested review of this revision.Sep 7 2020, 20:53
teamcity edited the summary of this revision. (Show Details)Sep 7 2020, 20:53

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12653: Diff 23354.Sep 7 2020, 21:05
Fabien accepted this revision.Sep 8 2020, 06:04
This revision is now accepted and ready to land.Sep 8 2020, 06:04
Closed by commit rABC39f861a08167: [backport#16689 2/2] Add missing fields in TransactionDescriptionString and… (authored by Antoine Riard <ariard@student.42.fr>, committed by majcosta). · Explain WhySep 8 2020, 13:56
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC39f861a08167: [backport#16689 2/2] Add missing fields in TransactionDescriptionString and….

Revision Contents
Changeset List

PathSize
src/
wallet/
92 lines

Diff 23368

View Options

src/wallet/rpcwallet.cpp

Loading...