Page MenuHomePhabricator
Differential D7387

[backport#17280] refactor: Change occurences of c_str() used with size() to data()
ClosedPublic
Actions

Authored by majcosta on Sep 7 2020, 22:13.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC81d108f6f25e: [backport#17280] refactor: Change occurences of c_str() used with size() to…
Summary

Fix occurences of c_str() used with size() to data() (Wladimir J. van der Laan)

Pull request description:

Using `data()` better communicates the intent here.

~~Also, depending on how `c_str()` is implemented, this fixes undefined behavior: The part of the string after the first NULL character might have undefined contents (or even be inaccessible, worst case).~~ Apparently [this is no longer an issue with C++11](https://github.com/bitcoin/bitcoin/pull/17281#discussion_r339742128).

Backport of Core PR17280

Test Plan
ninja check check-functional

Diff Detail

Event Timeline

majcosta created this revision.Sep 7 2020, 22:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 7 2020, 22:13
majcosta requested review of this revision.Sep 7 2020, 22:13
teamcity edited the summary of this revision. (Show Details)Sep 7 2020, 22:13

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12655: Diff 23357.Sep 7 2020, 22:25
deadalnix requested changes to this revision.Sep 8 2020, 03:43
deadalnix added a subscriber: deadalnix.

You need to get src/crypto/hkdf_sha256_32.cpp first.

This revision now requires changes to proceed.Sep 8 2020, 03:43
majcosta updated this revision to Diff 23376.Sep 8 2020, 14:45

rebased on top of D7396

Harbormaster completed remote builds in B12665: Diff 23376.Sep 8 2020, 15:02
deadalnix accepted this revision.Sep 8 2020, 22:31
This revision is now accepted and ready to land.Sep 8 2020, 22:31
Closed by commit rABC81d108f6f25e: [backport#17280] refactor: Change occurences of c_str() used with size() to… (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by majcosta). · Explain WhySep 9 2020, 01:23
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC81d108f6f25e: [backport#17280] refactor: Change occurences of c_str() used with size() to….

Revision Contents
Changeset List

PathSize
src/
2 lines
crypto/
2 lines
4 lines
4 lines
util/
4 lines
wallet/
2 lines

Diff 23376

View Options

src/bitcoin-cli.cpp

Loading...
View Options

src/crypto/hkdf_sha256_32.cpp

Loading...
View Options

src/fs.cpp

Loading...
View Options

src/httprpc.cpp

Loading...
View Options

src/util/strencodings.cpp

Loading...
View Options

src/wallet/crypter.cpp

Loading...