Page MenuHomePhabricator
Differential D7390

[CI] Automated commits: use nameref to get the current version
ClosedPublic
Actions

Authored by Fabien on Sep 8 2020, 09:18.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC693c5b2f8210: [CI] Automated commits: use nameref to get the current version
Summary

Using the standard output to get the version cause garbage to get into
the variable. Using nameref ensure only the version string is assigned
to the named variable.

Test Plan
COMMIT_TYPE=update-aur-version-bitcoin-abc \
  ./contrib/source-control-tools/automated-commits.sh

Diff Detail

Repository
rABC Bitcoin ABC
Branch
automated_namerefs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12658
Build 25417: Build Diffbuild-clang-10 · build-clang-tidy · build-diff · build-without-wallet
Build 25416: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 8 2020, 09:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 8 2020, 09:18
Fabien requested review of this revision.Sep 8 2020, 09:18
Harbormaster completed remote builds in B12658: Diff 23360.Sep 8 2020, 09:33
deadalnix accepted this revision.Sep 8 2020, 11:57
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
contrib/source-control-tools/automated-commits.sh
102

...

This revision is now accepted and ready to land.Sep 8 2020, 11:57
Fabien added inline comments.Sep 8 2020, 12:08
contrib/source-control-tools/automated-commits.sh
102

I'm working toward using a configuration file (just like the regular CI builds) that will remove the need for this script.

Closed by commit rABC693c5b2f8210: [CI] Automated commits: use nameref to get the current version (authored by Fabien). · Explain WhySep 8 2020, 12:41
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC693c5b2f8210: [CI] Automated commits: use nameref to get the current version.

Revision Contents
Changeset List

PathSize
contrib/
source-control-tools/
10 lines

Diff 23360

View Options

contrib/source-control-tools/automated-commits.sh

Loading...