Page MenuHomePhabricator

Migrate all page content to flexbox
ClosedPublic

Authored by jasonbcox on Sep 9 2020, 17:50.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCWEBb4924382712d: Migrate all page content to flexbox
Summary

This migrates the content structure of all pages to flexbox. As a result,
the subnav issues in the docs pages are fixed (no floating subnav over the footer).

It turns out that migrating the header and footer to flexbox is not strictly necessary
to complete before this patch. However, we can still simplify the DOM and fix up a lot
of the styling by doing so.

Considering that this patch impacts all pages on the site, I request that all reviewers
actually run the test plan as it's not feasible for me to test on multiple versions of
multiple browsers.

Depends on D7399

Test Plan

make serve
Navigate around and make sure nothing is broken using combinations of the following:

  • Browser
    • Firefox
    • Chrome
    • etc...
  • Screen size
    • small < 768px
    • medium < 900px
    • large > 900px
    • extra-large > 1200px
  • Page type

Diff Detail

Repository
rABCWEB Bitcoin ABC Website
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Fix inconsistent margins on small screens
  • Fix element sizing on blockquotes that contain long, unbroken words
majcosta added a subscriber: majcosta.

looks good. tested on Chromium and Brave.

This revision is now accepted and ready to land.Sep 9 2020, 19:10
This revision was automatically updated to reflect the committed changes.