Page MenuHomePhabricator

Fix logo link in non-prod environments
ClosedPublic

Authored by jasonbcox on Sep 9 2020, 21:42.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCWEB7474bdcc73a3: Fix logo link in non-prod environments
Summary

Using site.url will always link to the production environment,
which is both wrong and confusing when deployed in beta.
Interestingly, deploying with make serve appears to override
to localhost. The issue is only apparent in beta or when deployed
locally in a container.

Test Plan

make run
Navigate to localhost:8080 and click the logo in the upper left. It should take you to localhost, instead of prod as it does pre-patch.

Diff Detail

Repository
rABCWEB Bitcoin ABC Website
Branch
logo-link-fix
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12692
Build 25477: arc lint + arc unit

Event Timeline

jasonbcox edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Sep 9 2020, 23:50
This revision was automatically updated to reflect the committed changes.