[land-bot] Cleanup unnecessary brace expansion
ClosedPublic
Actions

Authored by jasonbcox on Sep 10 2020, 22:42.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC28eab9043981: [land-bot] Cleanup unnecessary brace expansion

Summary

The CI can copy this script out of the source tree if
this protection is necessary. Clearly doing it here is wrong.

I also took this opportunity to clean up some code that wasn't doing anything at all. (BUILD_DIR)

Test Plan

CONDUIT_TOKEN=<token> ./land-patch.sh Dxxxx with some accepted revision.
The revision will not land, but the patch should be applied and smoke tests run as expected.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

lb-cleanup

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12706
Build 25504: Build Diff	build-without-wallet · build-diff · build-clang-tidy · build-clang-10
Build 25503: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Sep 10 2020, 22:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 10 2020, 22:42

jasonbcox requested review of this revision.Sep 10 2020, 22:42

Harbormaster completed remote builds in B12706: Diff 23445.Sep 10 2020, 23:02

deadalnix accepted this revision.Sep 10 2020, 23:21

This revision is now accepted and ready to land.Sep 10 2020, 23:21

Closed by commit rABC28eab9043981: [land-bot] Cleanup unnecessary brace expansion (authored by jasonbcox). · Explain WhySep 10 2020, 23:27

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC28eab9043981: [land-bot] Cleanup unnecessary brace expansion.

Revision Contents
Changeset List

Path

Size

contrib/

source-control-tools/

land-patch.sh

43 lines

Diff 23445

View Options

contrib/source-control-tools/land-patch.sh

[land-bot] Cleanup unnecessary brace expansionClosedPublicActions