Differential D7469

[CMAKE] Rename the test wrapper util
ClosedPublic
Actions

Authored by Fabien on Sep 17 2020, 06:53.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC072de823ecf3: [CMAKE] Rename the test wrapper util

Summary

The test_wrapper.sh is currently used to run the unit tests, but is not
limited to this. This is in fact a generic wrapper for any runnable,
which silence the output unless it fails.
This diff renames the script to better reflect its intent.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_exe_wrapper

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12764
Build 25601: Build Diff	build-clang-tidy · build-clang-10 · build-without-wallet · build-diff
Build 25600: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 17 2020, 06:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 17 2020, 06:53

Fabien requested review of this revision.Sep 17 2020, 06:53

Fabien added a child revision: D7470: [CMAKE] Silent the man pages generation.Sep 17 2020, 07:02

Harbormaster completed remote builds in B12764: Diff 23544.Sep 17 2020, 07:04

run_silent is a pretty bad name, considering this is not running "silent". Running something silently is also not the only thing that this script is doing.

This revision now requires changes to proceed.Sep 17 2020, 12:34

Improve the name, and fix the arguments ordering in the comment

Harbormaster completed remote builds in B12768: Diff 23548.Sep 17 2020, 14:22

deadalnix accepted this revision.Sep 17 2020, 14:36

This revision is now accepted and ready to land.Sep 17 2020, 14:36

Closed by commit rABC072de823ecf3: [CMAKE] Rename the test wrapper util (authored by Fabien). · Explain WhySep 18 2020, 06:29

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC072de823ecf3: [CMAKE] Rename the test wrapper util.

Fabien removed a child revision: D7470: [CMAKE] Silent the man pages generation.Sep 18 2020, 07:47