The man pages generation is not part of the installation process, so
move it to doc/man where it belongs.
The install_manpage() interface now takes a list of pages to install, which can be empty.
This allows for adding the pages later by filling the MAN_PAGES target property.
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rABC14570c242b84: [CMAKE] Move the manpages generation logic to doc/man
ninja install-manpages
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Improve the API, it looks like it used to.
The interface now takes any number of man pages, and make them a property of the target.
The benefit is that the same interface can be use to directly list the pages to install or they can be added later by filling the property.
A generator expression ensure that the list of files to install is evaluated at build time from the target property.
doc/man/CMakeLists.txt | ||
---|---|---|
42 ↗ | (On Diff #23576) | If I add a new executable, it is more likely that I add an entry here or that I miss it completely? Why do executable need to be listed here AND where they are defined? This API does not make sense. |
If no man page is set, assume the target has generated man pages and add it to a global property.
The man page generation targets are created after all the CMakeLists.txt have been traversed and will use this property as an entry point.