Use pure python for functional tests schnorr computation
ClosedPublic
Actions

Authored by Fabien on Sep 18 2020, 15:25.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC31f0630d78c6: Use pure python for functional tests schnorr computation

Summary

This is a follow-up for D5965.
It converts our current schnorr.py library to use the framework from
key.py and remove openssl as a dependency for the functional tests.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

python_schnorr_no_openssl

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12797
Build 25667: Build Diff	build-clang-tidy · build-clang-10 · build-without-wallet · build-diff
Build 25666: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 18 2020, 15:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 18 2020, 15:25

Fabien requested review of this revision.Sep 18 2020, 15:25

Harbormaster completed remote builds in B12797: Diff 23585.Sep 18 2020, 15:33

deadalnix added a subscriber: deadalnix.Sep 18 2020, 23:18

deadalnix added inline comments.

test/functional/test_framework/key.py
210	The field size is 256bits, not this humongous number.
399	Is there a reason you implemented this rather than just picking something random like for ecdsa? This seems rather inconsistent, more code, and the benefit is dubious for the test framework.