Decouple archiving release notes from automated commits pipeline
ClosedPublic
Actions

Authored by jasonbcox on Sep 22 2020, 00:14.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC309ea9405477: Decouple archiving release notes from automated commits pipeline

Summary

This is the last recipe to decouple from the pipeline.
This patch also cleans up the now unnecessary logic regarding COMMIT_TYPE.

The next steps are to further decouple the staged changes from creating the commit
itself, which will make it easier to apply some of the recipes as a form of auto-gen
on top of other patches (ex: bumping package versions ON a version bump, rather than after).

Depends on D7504

Test Plan

./automated-commits.sh ./patch-recipes/archive-release-notes.sh

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Sep 22 2020, 00:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2020, 00:14

jasonbcox requested review of this revision.Sep 22 2020, 00:14

Harbormaster completed remote builds in B12834: Diff 23645.Sep 22 2020, 00:29

No, this whole version madness needs to stop. Version needs to be upgraded all at once. There is already a script that contains some of this. This is already very doubtful that this is a automated commit. If you touch this, actually build it right. You built it wrong once already.

This revision now requires changes to proceed.Sep 22 2020, 01:43

This is a move and cleanup in preparation for doing it correctly. See the summary.

That doesn't get you any closer to fixing your problem, but if you really want to figure it out by yourself, go for it.

This revision is now accepted and ready to land.Sep 22 2020, 16:29

Closed by commit rABC309ea9405477: Decouple archiving release notes from automated commits pipeline (authored by jasonbcox). · Explain WhySep 22 2020, 17:06

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC309ea9405477: Decouple archiving release notes from automated commits pipeline.