Differential D7528

IsUsedDestination should count any known single-key address
ClosedPublic
Actions

Authored by deadalnix on Sep 22 2020, 21:57.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC0af2f31d85fe: IsUsedDestination should count any known single-key address

Summary

This is a backport of Core PR17621

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr17621

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12866
Build 25802: Build Diff	build-diff · build-without-wallet · build-clang-tidy · build-clang-10
Build 25801: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 22 2020, 21:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2020, 21:57

deadalnix requested review of this revision.Sep 22 2020, 21:57

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12866: Diff 23696.Sep 22 2020, 22:19

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

[0m[0;32mrpc_estimatefee.py                      | ✓ Passed  | 1 s
[0m[0;32mrpc_getblockfilter.py                   | ✓ Passed  | 1 s
[0m[0;32mrpc_getblockstats.py                    | ✓ Passed  | 1 s
[0m[0;32mrpc_getchaintips.py                     | ✓ Passed  | 3 s
[0m[0;32mrpc_help.py                             | ✓ Passed  | 1 s
[0m[0;32mrpc_invalidateblock.py                  | ✓ Passed  | 6 s
[0m[0;32mrpc_misc.py                             | ✓ Passed  | 1 s
[0m[0;32mrpc_named_arguments.py                  | ✓ Passed  | 1 s
[0m[0;32mrpc_net.py                              | ✓ Passed  | 1 s
[0m[0;32mrpc_preciousblock.py                    | ✓ Passed  | 1 s
[0m[0;32mrpc_psbt.py                             | ✓ Passed  | 36 s
[0m[0;32mrpc_scantxoutset.py                     | ✓ Passed  | 4 s
[0m[0;32mrpc_setban.py                           | ✓ Passed  | 2 s
[0m[0;32mrpc_signmessage.py                      | ✓ Passed  | 1 s
[0m[0;32mrpc_signrawtransaction.py               | ✓ Passed  | 1 s
[0m[0;32mrpc_txoutproof.py                       | ✓ Passed  | 2 s
[0m[0;32mrpc_uptime.py                           | ✓ Passed  | 1 s
[0m[0;32mrpc_users.py                            | ✓ Passed  | 2 s
[0m[0;32mrpc_whitelist.py                        | ✓ Passed  | 1 s
[0m[0;32mtool_wallet.py                          | ✓ Passed  | 4 s
[0m[0;32mwallet_abandonconflict.py               | ✓ Passed  | 12 s
[0m[0;32mwallet_address_types.py                 | ✓ Passed  | 18 s
[0m[0;32mwallet_avoidreuse.py                    | ✓ Passed  | 2 s
[0m[0;32mwallet_balance.py                       | ✓ Passed  | 10 s
[0m[0;32mwallet_basic.py                         | ✓ Passed  | 30 s
[0m[0;32mwallet_coinbase_category.py             | ✓ Passed  | 1 s
[0m[0;32mwallet_create_tx.py                     | ✓ Passed  | 7 s
[0m[0;32mwallet_createwallet.py                  | ✓ Passed  | 2 s
[0m[0;32mwallet_createwallet.py --usecli         | ✓ Passed  | 3 s
[0m[0;32mwallet_disable.py                       | ✓ Passed  | 0 s
[0m[0;32mwallet_dump.py                          | ✓ Passed  | 3 s
[0m[0;32mwallet_encryption.py                    | ✓ Passed  | 5 s
[0m[0;32mwallet_groups.py                        | ✓ Passed  | 9 s
[0m[0;32mwallet_hd.py                            | ✓ Passed  | 5 s
[0m[0;32mwallet_import_rescan.py                 | ✓ Passed  | 7 s
[0m[0;32mwallet_import_with_label.py             | ✓ Passed  | 1 s
[0m[0;32mwallet_importmulti.py                   | ✓ Passed  | 3 s
[0m[0;32mwallet_importprunedfunds.py             | ✓ Passed  | 2 s
[0m[0;32mwallet_keypool.py                       | ✓ Passed  | 3 s
[0m[0;32mwallet_keypool_topup.py                 | ✓ Passed  | 3 s
[0m[0;32mwallet_labels.py                        | ✓ Passed  | 1 s
[0m[0;32mwallet_listreceivedby.py                | ✓ Passed  | 8 s
[0m[0;32mwallet_listsinceblock.py                | ✓ Passed  | 4 s
[0m[0;32mwallet_listtransactions.py              | ✓ Passed  | 10 s
[0m[0;32mwallet_multiwallet.py                   | ✓ Passed  | 16 s
[0m[0;32mwallet_multiwallet.py --usecli          | ✓ Passed  | 20 s
[0m[0;32mwallet_reorgsrestore.py                 | ✓ Passed  | 3 s
[0m[0;32mwallet_resendwallettransactions.py      | ✓ Passed  | 15 s
[0m[0;32mwallet_txn_clone.py                     | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_clone.py --mineblock         | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_doublespend.py               | ✓ Passed  | 1 s
[0m[0;32mwallet_txn_doublespend.py --mineblock   | ✓ Passed  | 4 s
[0m[0;32mwallet_watchonly.py                     | ✓ Passed  | 1 s
[0m[0;32mwallet_watchonly.py --usecli            | ✓ Passed  | 1 s
[0m[0;32mwallet_zapwallettxes.py                 | ✓ Passed  | 5 s
[0m[1m
ALL                                     | ✓ Passed  | 709 s (accumulated) 
[0mRuntime: 142 s

Build build-diff timed out after 1200.0s

majcosta accepted this revision.Sep 22 2020, 23:41

This revision is now accepted and ready to land.Sep 22 2020, 23:41

rebase

This revision was landed with ongoing or failed builds.Sep 22 2020, 23:51

Closed by commit rABC0af2f31d85fe: IsUsedDestination should count any known single-key address (authored by Gregory Sanders <gsanders87@gmail.com>, committed by deadalnix). · Explain Why

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC0af2f31d85fe: IsUsedDestination should count any known single-key address.

Harbormaster completed remote builds in B12874: Diff 23706.Sep 23 2020, 00:15