Page MenuHomePhabricator

[fix] fix tsan zeromq flakiness
ClosedPublic

Authored by majcosta on Thu, Sep 24, 12:25.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCeaa916f521b7: [fix] fix tsan zeromq flakiness
Summary

In D7547 I've replaced our zmq tsan suppression race:libzmq for Core's zmq::* but that isn't sufficient. This properly suppresses current interface_zmq.py tsan warnings.

Test Plan
cmake .. -GNinja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DENABLE_SANITIZERS=thread
ninja
TSAN_OPTIONS="suppressions=/home/marco/dev/bitcoin-abc/test/sanitizer_suppressions/tsan" test_runner.py interface_zmq

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix requested changes to this revision.Thu, Sep 24, 13:04
deadalnix added a subscriber: deadalnix.

It would be preferable to lst the warning themselves, because silencing the whole zmq package is not exactly inviting confidence.

This revision now requires changes to proceed.Thu, Sep 24, 13:04

narrowed down the suppression

This revision is now accepted and ready to land.Thu, Sep 24, 14:49
This revision was automatically updated to reflect the committed changes.