Page MenuHomePhabricator
Differential D7549

[fix] fix tsan zeromq flakiness
ClosedPublic
Actions

Authored by majcosta on Sep 24 2020, 12:25.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCeaa916f521b7: [fix] fix tsan zeromq flakiness
Summary

In D7547 I've replaced our zmq tsan suppression race:libzmq for Core's zmq::* but that isn't sufficient. This properly suppresses current interface_zmq.py tsan warnings.

Test Plan
cmake .. -GNinja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DENABLE_SANITIZERS=thread
ninja
TSAN_OPTIONS="suppressions=/home/marco/dev/bitcoin-abc/test/sanitizer_suppressions/tsan" test_runner.py interface_zmq

Diff Detail

Event Timeline

majcosta created this revision.Sep 24 2020, 12:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 24 2020, 12:25
majcosta requested review of this revision.Sep 24 2020, 12:25
Harbormaster completed remote builds in B12896: Diff 23758.Sep 24 2020, 12:34
deadalnix requested changes to this revision.Sep 24 2020, 13:04
deadalnix added a subscriber: deadalnix.

It would be preferable to lst the warning themselves, because silencing the whole zmq package is not exactly inviting confidence.

This revision now requires changes to proceed.Sep 24 2020, 13:04
majcosta updated this revision to Diff 23759.Sep 24 2020, 14:24

narrowed down the suppression

Harbormaster completed remote builds in B12897: Diff 23759.Sep 24 2020, 14:36
deadalnix accepted this revision.Sep 24 2020, 14:49
This revision is now accepted and ready to land.Sep 24 2020, 14:49
Closed by commit rABCeaa916f521b7: [fix] fix tsan zeromq flakiness (authored by majcosta). · Explain WhySep 24 2020, 15:06
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCeaa916f521b7: [fix] fix tsan zeromq flakiness.

Revision Contents
Changeset List

PathSize
test/
sanitizer_suppressions/
2 lines

Diff 23759

View Options

test/sanitizer_suppressions/tsan

Loading...