Page MenuHomePhabricator
Differential D7550

[refactor] remove #include <validation.h> from zmqnotificationinterface.cpp
ClosedPublic
Actions

Authored by majcosta on Sep 24 2020, 14:27.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC9c533d592417: [refactor] remove #include <validation.h> from zmqnotificationinterface.cpp
Summary

upcoming PR16443 adds an #include <txdb.h> to validation.h which makes
zmq want leveldb symbols. this is the first step towards avoiding that and
a generally Good Thing To Do. #include <primitives/block.h> will do.

Test Plan
ninja check check-functional

Diff Detail

Event Timeline

majcosta created this revision.Sep 24 2020, 14:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 24 2020, 14:27
majcosta requested review of this revision.Sep 24 2020, 14:27
teamcity edited the summary of this revision. (Show Details)Sep 24 2020, 14:28

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12898: Diff 23760.Sep 24 2020, 14:39
deadalnix accepted this revision.Sep 24 2020, 14:46
This revision is now accepted and ready to land.Sep 24 2020, 14:46
Closed by commit rABC9c533d592417: [refactor] remove #include <validation.h> from zmqnotificationinterface.cpp (authored by majcosta). · Explain WhySep 24 2020, 15:05
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC9c533d592417: [refactor] remove #include <validation.h> from zmqnotificationinterface.cpp.

Revision Contents
Changeset List

PathSize
src/
zmq/
2 lines

Diff 23760

View Options

src/zmq/zmqnotificationinterface.cpp

Loading...