Page MenuHomePhabricator
Differential D7563

refactor: Remove unused signal
ClosedPublic
Actions

Authored by PiRK on Sep 25 2020, 09:29.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCdb7a43013bdd: refactor: Remove unused signal
Summary

WalletView::showNormalIfMinimized() signal was introduced in #2872.

The only signal emit command was removed in #3144

Backport of Bitcoin Core PR17499

Test Plan

ninja && ninja check

Diff Detail

Event Timeline

PiRK created this revision.Sep 25 2020, 09:29
Owners added a reviewer: Restricted Owners Package.Sep 25 2020, 09:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 25 2020, 09:29
PiRK requested review of this revision.Sep 25 2020, 09:29
Harbormaster completed remote builds in B12912: Diff 23783.Sep 25 2020, 09:38
Fabien requested changes to this revision.Sep 25 2020, 10:06
Fabien added a subscriber: Fabien.

Please add to PR number to the summary

This revision now requires changes to proceed.Sep 25 2020, 10:06
PiRK updated this revision to Diff 23788.Sep 25 2020, 10:34

change commit message to include PR#

PiRK edited the summary of this revision. (Show Details)Sep 25 2020, 10:35
Harbormaster completed remote builds in B12915: Diff 23788.Sep 25 2020, 10:50
Fabien accepted this revision.Sep 25 2020, 11:04
This revision is now accepted and ready to land.Sep 25 2020, 11:04
Closed by commit rABCdb7a43013bdd: refactor: Remove unused signal (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhySep 25 2020, 11:26
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCdb7a43013bdd: refactor: Remove unused signal.

Revision Contents
Changeset List

PathSize
src/
qt/
4 lines
2 lines

Diff 23788

View Options

src/qt/walletframe.cpp

Loading...
View Options

src/qt/walletview.h

Loading...