Page MenuHomePhabricator
Differential D7564

refactor: Use proper MAX_SCRIPT_ELEMENT_SIZE const
ClosedPublic
Actions

Authored by PiRK on Sep 25 2020, 09:55.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC410759abbd07: refactor: Use proper MAX_SCRIPT_ELEMENT_SIZE const
Summary

This PR replaces well-known "magic" numbers with proper MAX_SCRIPT_ELEMENT_SIZE constants.

Backport of Bitcoin Core PR17439

Test Plan

ninja && ninja check

Diff Detail

Event Timeline

PiRK created this revision.Sep 25 2020, 09:55
Owners added a reviewer: Restricted Owners Package.Sep 25 2020, 09:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 25 2020, 09:55
PiRK requested review of this revision.Sep 25 2020, 09:55
teamcity edited the summary of this revision. (Show Details)Sep 25 2020, 09:55

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12914: Diff 23785.Sep 25 2020, 10:07
Fabien accepted this revision.Sep 25 2020, 10:11
This revision is now accepted and ready to land.Sep 25 2020, 10:11
Closed by commit rABC410759abbd07: refactor: Use proper MAX_SCRIPT_ELEMENT_SIZE const (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhySep 25 2020, 10:30
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC410759abbd07: refactor: Use proper MAX_SCRIPT_ELEMENT_SIZE const.

Revision Contents
Changeset List

PathSize
src/
script/
6 lines

Diff 23785

View Options

src/script/descriptor.cpp

Loading...