[backport]Give WalletModel::UnlockContext move semantics
ClosedPublic
Actions

Authored by PiRK on Sep 25 2020, 13:23.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCdeb7d1c0ff41: [backport]Give WalletModel::UnlockContext move semantics

Summary

WalletModel::UnlockContext seems to implement "move upon copy" semantics; with C++11 this can be done more safely using move semantics (making attempts to actually copy fail instead).

Backport of Core PR16001

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 25 2020, 13:23

Owners added a reviewer: Restricted Owners Package.Sep 25 2020, 13:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 25 2020, 13:23

PiRK requested review of this revision.Sep 25 2020, 13:23

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Sep 25 2020, 13:25

This revision is now accepted and ready to land.Sep 25 2020, 13:25

Harbormaster completed remote builds in B12918: Diff 23792.Sep 25 2020, 13:31

Closed by commit rABCdeb7d1c0ff41: [backport]Give WalletModel::UnlockContext move semantics (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by PiRK). · Explain WhySep 25 2020, 14:03

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCdeb7d1c0ff41: [backport]Give WalletModel::UnlockContext move semantics.

Revision Contents
Changeset List

Path

Size

src/

qt/

walletmodel.h

13 lines

walletmodel.cpp

2 lines

Diff 23795

View Options

src/qt/walletmodel.h