[backport]Give WalletModel::UnlockContext move semantics
deb7d1c0ff41
Actions

Description

[backport]Give WalletModel::UnlockContext move semantics

Summary:
WalletModel::UnlockContext seems to implement "move upon copy" semantics; with C++11 this can be done more safely using move semantics (making attempts to actually copy fail instead).

Backport of Core PR16001

Test Plan: ninja check

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7567

Details

Provenance

Pieter Wuille <pieter.wuille@gmail.com>	Authored on May 10 2019, 01:07
PiRK	Committed on Sep 25 2020, 14:03
PiRK	Pushed on Sep 25 2020, 14:03

Reviewer

Restricted Owners Package

Differential Revision

D7567: [backport]Give WalletModel::UnlockContext move semantics

Parents

rABC231b37f3ea53: refactor: Remove unused CExt{Pub,}Key (de)serialization methods

Branches

Unknown

Tags

Unknown

Event Timeline

PiRK committed rABCdeb7d1c0ff41: [backport]Give WalletModel::UnlockContext move semantics (authored by Pieter Wuille <pieter.wuille@gmail.com>).Sep 25 2020, 14:03

PiRK added an edge: D7567: [backport]Give WalletModel::UnlockContext move semantics.

Changes (2)

Path

Size

src/

qt/

walletmodel.cpp

walletmodel.h

rABCdeb7d1c0ff41

View Options

src/qt/walletmodel.cpp