Page MenuHomePhabricator
Differential D7568

[Backport] gui: Fix start timer from non QThread
ClosedPublic
Actions

Authored by PiRK on Sep 25 2020, 13:59.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCe03979f898ff: [Backport] gui: Fix start timer from non QThread
Summary

This fixes a bug related to a QTimer that in some situation
can be started from outside a QThread.

Backport of Core PR17120

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 25 2020, 13:59
Owners added a reviewer: Restricted Owners Package.Sep 25 2020, 13:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 25 2020, 13:59
PiRK requested review of this revision.Sep 25 2020, 13:59
teamcity edited the summary of this revision. (Show Details)Sep 25 2020, 13:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12919: Diff 23793.Sep 25 2020, 14:11
deadalnix requested changes to this revision.Sep 25 2020, 14:26
deadalnix added a subscriber: deadalnix.

The PR is not a PR.

This revision now requires changes to proceed.Sep 25 2020, 14:26
PiRK edited the summary of this revision. (Show Details)Sep 25 2020, 15:16
In D7568#179568, @deadalnix wrote:

The PR is not a PR.

Sorry about that. I updated the revision message.

PiRK requested review of this revision.Sep 26 2020, 05:43
deadalnix accepted this revision.Sep 27 2020, 14:27
deadalnix added inline comments.
src/qt/walletmodel.cpp
49 ↗(On Diff #23793)

Isn't this a memory leak?

This revision is now accepted and ready to land.Sep 27 2020, 14:27
PiRK added inline comments.Sep 28 2020, 06:43
src/qt/walletmodel.cpp
49 ↗(On Diff #23793)

QObjects are deleted when their parent is deleted. The parents chain seems to be properly set.

BitcoinApplication -> WalletController -> WalletModel -> timer

Closed by commit rABCe03979f898ff: [Backport] gui: Fix start timer from non QThread (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by PiRK). · Explain WhySep 28 2020, 09:16
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCe03979f898ff: [Backport] gui: Fix start timer from non QThread.

Revision Contents
Changeset List

PathSize
src/
qt/
7 lines
7 lines
13 lines

Diff 23876

View Options

src/qt/walletcontroller.cpp

Loading...
View Options

src/qt/walletmodel.h

Loading...
View Options

src/qt/walletmodel.cpp

Loading...