Page MenuHomePhabricator
Differential D7583

build: fix OpenSSL EC detection on macOS
ClosedPublic
Actions

Authored by deadalnix on Sep 27 2020, 21:25.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC40f898ad1385: build: fix OpenSSL EC detection on macOS
Summary
  • build: add SECP_TEST_INCLUDES to bench_verify CPPFLAGS

This is needed so that bench_verify gets CRYPTO_CPPFLAGS, which would
otherwise not be included, at least on macOS.

This is a backport of linsecp256k1 PR735

Test Plan

I don't have an OSX machine, so \o/

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 27 2020, 21:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2020, 21:25
deadalnix requested review of this revision.Sep 27 2020, 21:25
teamcity edited the summary of this revision. (Show Details)Sep 27 2020, 21:25

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12945: Diff 23835.Sep 27 2020, 21:34
majcosta accepted this revision.Sep 27 2020, 21:46
This revision is now accepted and ready to land.Sep 27 2020, 21:46
Closed by commit rABC40f898ad1385: build: fix OpenSSL EC detection on macOS (authored by fanquake <fanquake@gmail.com>, committed by deadalnix). · Explain WhySep 27 2020, 21:51
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC40f898ad1385: build: fix OpenSSL EC detection on macOS.

Revision Contents
Changeset List

PathSize
src/
secp256k1/
2 lines
build-aux/
m4/
3 lines
3 lines

Diff 23843

View Options

src/secp256k1/Makefile.am

Loading...
View Options

src/secp256k1/build-aux/m4/bitcoin_secp.m4

Loading...
View Options

src/secp256k1/configure.ac

Loading...