Page MenuHomePhabricator
Differential D7599

Avoid linking libcrypto in the valgrind ct test.
ClosedPublic
Actions

Authored by deadalnix on Sep 27 2020, 23:13.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC8b8d8b7f29fc: Avoid linking libcrypto in the valgrind ct test.
Summary

Libcrypto isn't useful here and on some systems UB in OpenSSL's
init causes failures.

Fixes #775.

This is a backport of secp256k1 PR795

Test Plan
ninja check-secp256k1

Diff Detail

Event Timeline

deadalnix created this revision.Sep 27 2020, 23:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2020, 23:13
deadalnix requested review of this revision.Sep 27 2020, 23:13
teamcity edited the summary of this revision. (Show Details)Sep 27 2020, 23:13

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta accepted this revision.Sep 27 2020, 23:20
This revision is now accepted and ready to land.Sep 27 2020, 23:20
This revision was landed with ongoing or failed builds.Sep 27 2020, 23:23
Closed by commit rABC8b8d8b7f29fc: Avoid linking libcrypto in the valgrind ct test. (authored by Gregory Maxwell <greg@xiph.org>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC8b8d8b7f29fc: Avoid linking libcrypto in the valgrind ct test..
Harbormaster completed remote builds in B12965: Diff 23869.Sep 27 2020, 23:38

Revision Contents
Changeset List

PathSize
src/
secp256k1/
2 lines

Diff 23869

View Options

src/secp256k1/Makefile.am

Loading...