Page MenuHomePhabricator
Differential D7608

Prevent ints from wrapping around in scratch space functions
ClosedPublic
Actions

Authored by deadalnix on Sep 28 2020, 15:44.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCec5ca0931f3b: Prevent ints from wrapping around in scratch space functions
Summary
  • Add check preventing integer multiplication wrapping around in scratch_max_allocation
  • Add check preventing rounding to alignment from wrapping around in scratch_alloc
  • Use ROUND_TO_ALIGN in scratch_create
  • Don't assume that ALIGNMENT > 1 in tests

This is a backport of secp256k1 PR648

Test Plan
ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 28 2020, 15:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 28 2020, 15:44
deadalnix requested review of this revision.Sep 28 2020, 15:44
teamcity edited the summary of this revision. (Show Details)Sep 28 2020, 15:44

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12975: Diff 23887.Sep 28 2020, 16:03
jasonbcox accepted this revision.Sep 28 2020, 16:36
This revision is now accepted and ready to land.Sep 28 2020, 16:36
Closed by commit rABCec5ca0931f3b: Prevent ints from wrapping around in scratch space functions (authored by Jonas Nick <jonasd.nick@gmail.com>, committed by deadalnix). · Explain WhySep 28 2020, 16:38
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCec5ca0931f3b: Prevent ints from wrapping around in scratch space functions.

Revision Contents
Changeset List

PathSize
src/
secp256k1/
src/
15 lines
16 lines

Diff 23902

View Options

src/secp256k1/src/scratch_impl.h

Loading...
View Options

src/secp256k1/src/tests.c

Loading...