Page MenuHomePhabricator

Fix Jacobi benchmarks and other benchmark improvements
ClosedPublic

Authored by deadalnix on Mon, Sep 28, 16:09.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCaade0f932f0e: Fix Jacobi benchmarks and other benchmark improvements
Summary
  • Rename bench_internal variables

The _x and _y suffices are confusing; they don't actually correspond
to X and Y coordinates. Instead replace them with arrays.

  • Randomize the Z coordinates in bench_internal

Also increase the number of fe inputs.

  • Make jacobi benchmarks vary inputs

Also make the num_jacobi benchmark use the scalar order as modulus,
instead of a random number.

  • Add benchmark for secp256k1_ge_set_gej_var

This is a backport of secp256k1 PR797

Test Plan
ninja bench-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Mon, Sep 28, 16:45