HomePhabricator

Fix Jacobi benchmarks and other benchmark improvements

Description

Fix Jacobi benchmarks and other benchmark improvements

Summary:

  • Rename bench_internal variables

The _x and _y suffices are confusing; they don't actually correspond
to X and Y coordinates. Instead replace them with arrays.

  • Randomize the Z coordinates in bench_internal

Also increase the number of fe inputs.

  • Make jacobi benchmarks vary inputs

Also make the num_jacobi benchmark use the scalar order as modulus,
instead of a random number.

  • Add benchmark for secp256k1_ge_set_gej_var

This is a backport of secp256k1 PR797

Test Plan:

ninja bench-secp256k1

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D7612

Details

Provenance
Pieter Wuille <pieter@wuille.net>Authored on Aug 11 2020, 17:50
deadalnixCommitted on Sep 28 2020, 17:03
deadalnixPushed on Sep 28 2020, 17:03
Reviewer
Restricted Project
Differential Revision
D7612: Fix Jacobi benchmarks and other benchmark improvements
Parents
rABCec5ca0931f3b: Prevent ints from wrapping around in scratch space functions
Branches
Unknown
Tags
Unknown