Differential D7628

[backport#13868] Remove unused fScriptChecks parameter from CheckInputs
ClosedPublic
Actions

Authored by majcosta on Sep 28 2020, 23:16.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCe98032485118: [backport#13868] Remove unused fScriptChecks parameter from CheckInputs

Summary

Remove unused fScriptChecks parameter from CheckInputs (Matt Corallo)

Pull request description:

fScriptChecks = false just short-circuits the entire function, so
passing it in is entirely useless.

This is extracted from #13233 /cc TheBlueMatt.

Recommend reviewing with `git show --ignore-all-space`, i.e.:
https://github.com/bitcoin/bitcoin/pull/13868/files?w=1

Backport of Core PR13868

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 28 2020, 23:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 28 2020, 23:16

majcosta requested review of this revision.Sep 28 2020, 23:16

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12999: Diff 23933.Sep 28 2020, 23:26

deadalnix accepted this revision.Sep 28 2020, 23:30

This revision is now accepted and ready to land.Sep 28 2020, 23:30

Closed by commit rABCe98032485118: [backport#13868] Remove unused fScriptChecks parameter from CheckInputs (authored by fanquake <fanquake@gmail.com>, committed by majcosta). · Explain WhySep 29 2020, 00:28

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCe98032485118: [backport#13868] Remove unused fScriptChecks parameter from CheckInputs.

Revision Contents
Changeset List

Path

Size

src/

test/

txvalidationcache_tests.cpp

56 lines

15 lines

60 lines

Diff 23935

src/test/txvalidationcache_tests.cpp

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...