Page MenuHomePhabricator
Differential D7638

extrakeys: Init empty experimental module
ClosedPublic
Actions

Authored by deadalnix on Sep 29 2020, 10:19.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3374da576f72: extrakeys: Init empty experimental module
Summary

This is to prepare for xonly_pubkeys and keypairs.

This is a partial backport of secp256k1 PR558 : https://github.com/bitcoin-core/secp256k1/pull/558/commits/47e6618e11813cfabe91f0909ca031f960cb7dd4

Test Plan
ninja check-secp256k1

And with the module on:

cmake -GNinja .. -DSECP256K1_ENABLE_MODULE_EXTRAKEYS=On
ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 29 2020, 10:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2020, 10:20
deadalnix requested review of this revision.Sep 29 2020, 10:20
teamcity edited the summary of this revision. (Show Details)Sep 29 2020, 10:20

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix added a child revision: D7639: extrakeys: Add xonly_pubkey with serialize, parse and from_pubkey.Sep 29 2020, 10:23
Fabien requested changes to this revision.Sep 29 2020, 10:24
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/secp256k1/configure.ac
485 ↗(On Diff #23957)

Your cherry-picked is incomplete

This revision now requires changes to proceed.Sep 29 2020, 10:24
deadalnix added inline comments.Sep 29 2020, 10:29
src/secp256k1/configure.ac
485 ↗(On Diff #23957)

Holy crap, I did not pay attention to the autotool build. Fixing this right away.

deadalnix updated this revision to Diff 23962.Sep 29 2020, 10:31

Fix autotool build

Fabien accepted this revision.Sep 29 2020, 10:36
Fabien added inline comments.
src/secp256k1/CMakeLists.txt
232 ↗(On Diff #23962)

Disable by default since it's marked as experimental (and is disbabled in the autotools build)

This revision is now accepted and ready to land.Sep 29 2020, 10:36
This revision was landed with ongoing or failed builds.Sep 29 2020, 10:42
Closed by commit rABC3374da576f72: extrakeys: Init empty experimental module (authored by Jonas Nick <jonasd.nick@gmail.com>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC3374da576f72: extrakeys: Init empty experimental module.
Harbormaster completed remote builds in B13014: Diff 23957.Sep 29 2020, 10:47
Harbormaster completed remote builds in B13018: Diff 23962.Sep 29 2020, 11:06

Revision Contents
Changeset List

PathSize
src/
secp256k1/
7 lines
4 lines
15 lines
include/
14 lines
src/
modules/
extrakeys/
3 lines
13 lines
16 lines
4 lines
8 lines

Diff 23967

View Options

src/secp256k1/CMakeLists.txt

Loading...
View Options

src/secp256k1/Makefile.am

Loading...
View Options

src/secp256k1/configure.ac

Loading...
View Options

src/secp256k1/include/secp256k1_extrakeys.h

Loading...
View Options

src/secp256k1/src/modules/extrakeys/Makefile.am.include

Loading...
View Options

src/secp256k1/src/modules/extrakeys/main_impl.h

Loading...
View Options

src/secp256k1/src/modules/extrakeys/tests_impl.h

Loading...
View Options

src/secp256k1/src/secp256k1.c

Loading...
View Options

src/secp256k1/src/tests.c

Loading...